fix: start-after/end-before order in _rst_include_trim#876
Merged
mhils merged 3 commits intomitmproxy:mainfrom Apr 13, 2026
Merged
fix: start-after/end-before order in _rst_include_trim#876mhils merged 3 commits intomitmproxy:mainfrom
mhils merged 3 commits intomitmproxy:mainfrom
Conversation
mhils
approved these changes
Apr 10, 2026
Member
mhils
left a comment
mhils
left a comment
There was a problem hiding this comment.
Thank you! 😃 Do you want to add a CHANGELOG entry?
Contributor
Author
Sure :) |
* Added change log entry
JohanKarlbergg
force-pushed
the
fix/rst-include-trim-order
branch
from
4fc636d to
b762a36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
It looks like
start-afterandend-beforemay be applied in the wrong order. From how I read the docutils spec,end-beforeis defined as matching content before the first occurrence of the specified text, but still after anystart-aftertext. That suggests the current behavior might be reversed, though I may be misunderstanding it.My use case is to include the text between two markers, for example
"""and""".https://docutils.sourceforge.io/docs/ref/rst/directives.html#include-options